Consolidate edittext alert dialogs into one common layout #6720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Jul 27, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I think setMaxLines(1); and setSaveEnabled(true); can be specified in the dialog_edit_text.xml, since:
- we want a single line dialog everywhere
- we want the dialog content to not be lost on orientation changes everywhere: https://developer.android.com/reference/android/view/View.html#attr_android:saveEnabled
In particular, only android:maxLines="1" needs to be put in the xml, as android:saveEnabled is true by default.
By the way, is the AlertDialog buttons being white something we can fix? It looks bad imo, and them being red only seems to take effect in the settings screens.
I think we might have to customize the accentColor for dialog buttons. But let's leave this to another PR.
Member
Author
|
@Stypox Thanks! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
(Ignore the comments disabled thing in the background of the second comparison)
By the way, is the AlertDialog buttons being white something we can fix? It looks bad imo, and them being red only seems to take effect in the settings screens.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence